[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen stable-4.10] ns16550/PCI: fix skipping of devices
commit 95e2f57788b5e18149578d34bf4af8802048b9bb Author: Jan Beulich <jbeulich@xxxxxxxx> AuthorDate: Fri Feb 1 11:44:13 2019 +0100 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Fri Feb 1 11:44:13 2019 +0100 ns16550/PCI: fix skipping of devices Selecting between single/multiple BAR mode should happen after checking whether to skip the present device, or else multi-BAR devices won't be skipped correctly, due to port_idx getting set to zero in that case. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx> master commit: c34fe0468acc61aca62422483c37a1309708f1cb master date: 2018-11-30 12:07:33 +0100 --- xen/drivers/char/ns16550.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index f32dbd3247..863647ce58 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1037,18 +1037,18 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) } } - if ( !param->bar0 ) - { - bar_idx = idx; - port_idx = 0; - } - if ( port_idx >= param->max_ports ) { idx -= param->max_ports; continue; } + if ( !param->bar0 ) + { + bar_idx = idx; + port_idx = 0; + } + uart->io_base = 0; bar = pci_conf_read32(0, b, d, f, PCI_BASE_ADDRESS_0 + bar_idx*4); -- generated by git-patchbot for /home/xen/git/xen.git#stable-4.10 _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/xen-changelog
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |