[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] xen/arm: psci: Populate arm_smccc_res on PSCI_FEATURES call

commit 83ba64c3ebf0e8d3834e3e5b79acb2ceb2cd9bba
Author:     Julien Grall <julien.grall@xxxxxxx>
AuthorDate: Mon Feb 18 09:42:27 2019 +0000
Commit:     Stefano Stabellini <sstabellini@xxxxxxxxxx>
CommitDate: Mon Feb 25 14:27:26 2019 -0800

    xen/arm: psci: Populate arm_smccc_res on PSCI_FEATURES call
    Commit 0bc6a68da5 "xen/arm: Replace call_smc with arm_smccc_smc"
    mistakenly forgot to populate arm_smccc_res. So a garbage value was
    used as return value.
    Coverity-ID: 1476827
    Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
    Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
 xen/arch/arm/psci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index d23cb8e76e..0c90c2305c 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -87,7 +87,7 @@ static int __init psci_features(uint32_t psci_func_id)
     if ( psci_ver < PSCI_VERSION(1, 0) )
         return PSCI_NOT_SUPPORTED;
-    arm_smccc_smc(PSCI_1_0_FN32_PSCI_FEATURES, psci_func_id, NULL);
+    arm_smccc_smc(PSCI_1_0_FN32_PSCI_FEATURES, psci_func_id, &res);
     return PSCI_RET(res);
generated by git-patchbot for /home/xen/git/xen.git#master

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.