[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] xen/arm: domain_build: Panic message should end with a newline

commit 1c858928009c51178a9c6cac9e42343ee81dfe37
Author:     Julien Grall <julien.grall@xxxxxxx>
AuthorDate: Mon Feb 18 10:21:06 2019 +0000
Commit:     Stefano Stabellini <sstabellini@xxxxxxxxxx>
CommitDate: Mon Feb 25 14:28:07 2019 -0800

    xen/arm: domain_build: Panic message should end with a newline
    Since commit 25eb5eec79 "xen: Fix inconsistent callers of panic()" all
    the panic message should end with a newline. Unfortunately, some
    commits pushed afterwards does not follow the rule.
    Modify the offending panic messages to avoid more inconsistency.
    Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
 xen/arch/arm/domain_build.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index c92f8c6be1..d9836779d1 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1580,7 +1580,7 @@ static int __init make_gic_domU_node(const struct domain 
*d, void *fdt)
     case GIC_V2:
         return make_gicv2_domU_node(d, fdt);
-        panic("Unsupported GIC version");
+        panic("Unsupported GIC version\n");
@@ -2086,12 +2086,12 @@ void __init create_domUs(void)
         d = domain_create(++max_init_domid, &d_cfg, false);
         if ( IS_ERR(d) )
-            panic("Error creating domain %s", dt_node_name(node));
+            panic("Error creating domain %s\n", dt_node_name(node));
         d->is_console = true;
         if ( construct_domU(d, node) != 0 )
-            panic("Could not set up domain %s", dt_node_name(node));
+            panic("Could not set up domain %s\n", dt_node_name(node));
generated by git-patchbot for /home/xen/git/xen.git#master

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.