[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen staging] tools/libfsimage: Add `XEN' to environment variable name

commit 2215a8b6da655f8d7492b8981945e68459f3cf4e
Author:     Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
AuthorDate: Tue Mar 5 15:31:32 2019 +0000
Commit:     Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
CommitDate: Tue Mar 5 16:25:08 2019 +0000

    tools/libfsimage: Add `XEN' to environment variable name
    This library, which is private to Xen and was properly namespaced in
      tools/libfsimage: Add `xen' to .h names and principal .so name
    honours an environment variable to override the directory where
    shared objects (ie filesystem plugins) are to be loaded from.
    Rename that variable from FSIMAGE_FSDIR to XEN_FSIMAGE_FSDIR, to give
    it a proper namespace prefix.
    Nothing in xen.git sets this variable.  The three hits for the string
    `FSIMAGE_FSDIR' are this getenv, and two references to a compile-time
    manifest constant which provides the default value (the -D which sets
    it, and the place it is used).
    I have also checked the current Debian Xen package in buster and the
    variable is not set there either.
    CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    CC: Jan Beulich <JBeulich@xxxxxxxx>
    CC: George Dunlap <george.dunlap@xxxxxxxxxx>
    Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
 tools/libfsimage/common/fsimage_plugin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libfsimage/common/fsimage_plugin.c 
index 44ebcf3142..de1412b423 100644
--- a/tools/libfsimage/common/fsimage_plugin.c
+++ b/tools/libfsimage/common/fsimage_plugin.c
@@ -121,7 +121,7 @@ fail:
 static int load_plugins(void)
-       const char *fsdir = getenv("FSIMAGE_FSDIR");
+       const char *fsdir = getenv("XEN_FSIMAGE_FSDIR");
        struct dirent *dp = NULL;
        DIR *dir = NULL;
        char *tmp = NULL;
generated by git-patchbot for /home/xen/git/xen.git#staging

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.