[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] kexec: suppress bogus warning



commit b49225dc9df336405292dc08862b4c7c9d887bd6
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Mar 12 14:39:13 2019 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Mar 12 14:39:13 2019 +0100

    kexec: suppress bogus warning
    
    Till now "crashkernel=1G-16G:1M" causes
    
    (XEN) crashkernel: '' ignored
    (XEN) parameter "crashkernel" has invalid value "1G-16G:1M", rc=-22!
    
    Don't emit the "ignored" warning when there's no placement specification
    and the tail of the specified option is actually empty.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/common/kexec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index c14cbb2b9c..a262cc5a18 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -173,7 +173,7 @@ static int __init parse_crashkernel(const char *str)
             kexec_crash_area_limit = parse_size_and_unit(cur = str + 1, &str);
         else if ( !strncmp(str, ",below=", 7) )
             kexec_crash_area_limit = parse_size_and_unit(cur = str + 7, &str);
-        else
+        else if ( *str )
         {
             printk(XENLOG_WARNING "crashkernel: '%s' ignored\n", str);
             rc = -EINVAL;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.