[Xen-changelog] [xen master] x86emul: test harness adjustments for AVX512F S/G insns

[patchbot@xxxxxxx]

commit 5f55389d696054e97ad0805989bc28b1dcc4ccc7
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Thu Jul 4 17:43:57 2019 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Jul 4 17:43:57 2019 +0200

    x86emul: test harness adjustments for AVX512F S/G insns
    
    There was an encoding mistake in the EVEX Disp8 test code, which was
    benign (due to %rdx getting set to zero) to all non-vSIB tests as it
    mistakenly encoded <disp8>(%rdx,%rdx) instead of <disp8>(%rdx,%riz). In
    the vSIB case this meant <disp8>(%rdx,%zmm2) instead of the intended
    <disp8>(%rdx,%zmm4).
    
    Likewise the access count check wasn't entirely correct for the S/G
    case: In the quad-word-index but dword-data case only half the number
    of full vector elements get accessed.
    
    As an unrelated change in the main test harness source file distinguish
    the "n/a" messages by bitness.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 tools/tests/x86_emulator/evex-disp8.c        | 5 +++--
 tools/tests/x86_emulator/test_x86_emulator.c | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/tools/tests/x86_emulator/evex-disp8.c 
b/tools/tests/x86_emulator/evex-disp8.c
index fcd2654666..88dcc53c63 100644
--- a/tools/tests/x86_emulator/evex-disp8.c
+++ b/tools/tests/x86_emulator/evex-disp8.c
@@ -698,7 +698,7 @@ static void test_one(const struct test *test, enum vl vl,
     instr[3] = evex.raw[2];
     instr[4] = test->opc;
     instr[5] = 0x44 | (test->ext << 3); /* ModR/M */
-    instr[6] = 0x12; /* SIB: base rDX, index none / xMM4 */
+    instr[6] = 0x22; /* SIB: base rDX, index none / xMM4 */
     instr[7] = 1; /* Disp8 */
     instr[8] = 0; /* immediate, if any */
 
@@ -718,7 +718,8 @@ static void test_one(const struct test *test, enum vl vl,
          if ( accessed[i] )
              goto fail;
     for ( ; i < (test->scale == SC_vl ? vsz : esz) + (sg ? esz : vsz); ++i )
-         if ( accessed[i] != (sg ? vsz / esz : 1) )
+         if ( accessed[i] != (sg ? (vsz / esz) >> (test->opc & 1 & !evex.w)
+                                 : 1) )
              goto fail;
     for ( ; i < ARRAY_SIZE(accessed); ++i )
          if ( accessed[i] )
diff --git a/tools/tests/x86_emulator/test_x86_emulator.c 
b/tools/tests/x86_emulator/test_x86_emulator.c
index 510ac93d53..b0924be06d 100644
--- a/tools/tests/x86_emulator/test_x86_emulator.c
+++ b/tools/tests/x86_emulator/test_x86_emulator.c
@@ -4260,7 +4260,7 @@ int main(int argc, char **argv)
 
         if ( !blobs[j].size )
         {
-            printf("%-39s n/a\n", blobs[j].name);
+            printf("%-39s n/a (%u-bit)\n", blobs[j].name, blobs[j].bitness);
             continue;
         }
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog