[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen staging] xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node()



commit 698b05d18dfe377abf07911dd1e9145c950f58c1
Author:     Julien Grall <julien.grall@xxxxxxx>
AuthorDate: Thu Aug 15 20:46:24 2019 +0100
Commit:     Julien Grall <julien.grall@xxxxxxx>
CommitDate: Wed Oct 2 09:24:42 2019 +0100

    xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node()
    
    None of the code since the last check of res modify the value. So the
    check can be removed.
    
    Coverity-ID: 1476824
    Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
    Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
    Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
 xen/arch/arm/domain_build.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 5709a77d4d..f049d0e7f9 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1661,8 +1661,7 @@ static int __init make_vpl011_uart_node(const struct 
domain *d, void *fdt)
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
                        GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
                        GUEST_PL011_SIZE);
-    if ( res )
-        return res;
+
     res = fdt_property(fdt, "reg", reg, sizeof(reg));
     if ( res )
         return res;
--
generated by git-patchbot for /home/xen/git/xen.git#staging

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.