[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen staging] xen/arm: cpuerrata: Match register size with value size in check_workaround_*



commit 6acd7dea7adfbe5553383a5133dd3ab6b8145afa
Author:     Julien Grall <julien.grall@xxxxxxx>
AuthorDate: Tue Mar 26 20:53:09 2019 +0000
Commit:     Julien Grall <julien.grall@xxxxxxx>
CommitDate: Thu Oct 3 11:38:30 2019 +0100

    xen/arm: cpuerrata: Match register size with value size in 
check_workaround_*
    
    Clang is pickier than GCC for the register size in asm statement. It
    expects the register size to match the value size.
    
    The asm statement expects a 32-bit (resp. 64-bit) value on Arm32
    (resp. Arm64) whereas the value is a boolean (Clang consider to be
    32-bit).
    
    It would be possible to impose 32-bit register for both architecture
    but this require the code to use __OP32. However, it does not really
    improve the assembly generated. Instead, replace switch the variable
    to use register_t.
    
    Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
    Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
 xen/include/asm-arm/cpuerrata.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/cpuerrata.h b/xen/include/asm-arm/cpuerrata.h
index 55ddfda272..88ef3ca934 100644
--- a/xen/include/asm-arm/cpuerrata.h
+++ b/xen/include/asm-arm/cpuerrata.h
@@ -14,7 +14,7 @@ static inline bool check_workaround_##erratum(void)           
  \
         return false;                                           \
     else                                                        \
     {                                                           \
-        bool ret;                                               \
+        register_t ret;                                         \
                                                                 \
         asm volatile (ALTERNATIVE("mov %0, #0",                 \
                                   "mov %0, #1",                 \
--
generated by git-patchbot for /home/xen/git/xen.git#staging

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.