[Xen-changelog] [xen master] domctl: return EEXIST from XEN_DOMCTL_createdomain...

[patchbot@xxxxxxx]

commit b162e65a7abbccd45fde608e44661d16d10bf00e
Author:     Paul Durrant <pdurrant@xxxxxxxxxx>
AuthorDate: Fri Jan 3 17:06:57 2020 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Jan 3 17:06:57 2020 +0100

    domctl: return EEXIST from XEN_DOMCTL_createdomain...
    
    ...if a specified domid is already in use.
    
    XEN_DOMCTL_createdomain allows a domid to be specified by its caller and
    will correctly fail if that domid is already in use. However the errno
    returned in this case will be EINVAL, making it indistinguishable from
    several other failures. Also a value of EINVAL does not seem appropriate
    as the specified domid is valid [1] but just not (transiently) available.
    
    [1] any invalid value passed in is ignored and causes Xen to choose an
        unused and valid value.
    
    Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
    Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 xen/common/domctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 03d0226039..650310e874 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -504,7 +504,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
u_domctl)
         dom = op->domain;
         if ( (dom > 0) && (dom < DOMID_FIRST_RESERVED) )
         {
-            ret = -EINVAL;
+            ret = -EEXIST;
             if ( !is_free_domid(dom) )
                 break;
         }
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog