[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen staging] xen/sched: remove pointless BUG_ON() in credit2

commit 6bb06bb0eb1528319998de602f969c474396c306
Author:     Juergen Gross <jgross@xxxxxxxx>
AuthorDate: Tue Feb 11 10:44:18 2020 +0100
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Tue Feb 11 10:55:38 2020 +0000

    xen/sched: remove pointless BUG_ON() in credit2
    The BUG_ON() at the top of csched2_context_saved() is completely
    pointless, as the ASSERT() just following it catches the same problem
    Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
    Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
 xen/common/sched/credit2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 231f87d960..f2752f27e2 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -2167,8 +2167,6 @@ csched2_context_saved(const struct scheduler *ops, struct 
sched_unit *unit)
     s_time_t now = NOW();
-    BUG_ON( !is_idle_unit(unit) &&
-            svc->rqd != c2rqd(ops, sched_unit_master(unit)));
     ASSERT(is_idle_unit(unit) ||
            svc->rqd == c2rqd(ops, sched_unit_master(unit)));
generated by git-patchbot for /home/xen/git/xen.git#staging

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.