[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] build: remove confusing comment on the %.s:%.S rule



commit 408d50108187eb2ffc93a1fae456629acb06aef1
Author:     Anthony PERARD <anthony.perard@xxxxxxxxxx>
AuthorDate: Wed Feb 26 17:41:37 2020 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Feb 26 17:41:37 2020 +0100

    build: remove confusing comment on the %.s:%.S rule
    
    That comment was introduce by 3943db776371 ("[XEN] Can be built
    -std=gnu99 (except for .S files).") to explain why CFLAGS was removed
    from the command line. The comment is already written where the
    -std=gnu flags gets remove from AFLAGS, no need to repeat it.
    
    Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Acked-by: Wei Liu <wl@xxxxxxx>
---
 xen/Rules.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/Rules.mk b/xen/Rules.mk
index d22a16d282..c21203351a 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -230,7 +230,6 @@ $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): 
%.init.o: %.o Makefile
 %.s: %.c Makefile
        $(CC) $(filter-out -Wa$(comma)%,$(CFLAGS)) -S $< -o $@
 
-# -std=gnu{89,99} gets confused by # as an end-of-line comment marker
 %.s: %.S Makefile
        $(CPP) $(filter-out -Wa$(comma)%,$(AFLAGS)) $< -o $@
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.