[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen staging-4.13] iotests: Restrict nbd Python tests to nbd

commit 593beeaf81964e890d0f7f40fa4bafcb9769ae35
Author:     Max Reitz <mreitz@xxxxxxxxxx>
AuthorDate: Mon Sep 2 21:33:19 2019 +0200
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Sun Oct 27 23:55:39 2019 -0500

    iotests: Restrict nbd Python tests to nbd
    We have two Python unittest-style tests that test NBD.  As such, they
    should specify supported_protocols=['nbd'] so they are skipped when the
    user wants to test some other protocol.
    Furthermore, we should restrict their choice of formats to 'raw'.  The
    idea of a protocol/format combination is to use some format over some
    protocol; but we always use the raw format over NBD.  It does not really
    matter what the NBD server uses on its end, and it is not a useful test
    of the respective format driver anyway.
    Signed-off-by: Max Reitz <mreitz@xxxxxxxxxx>
    Signed-off-by: Kevin Wolf <kwolf@xxxxxxxxxx>
    (cherry picked from commit 7c932a1d69a6d6ac5c0b615c11d191da3bbe9aa8)
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
 tests/qemu-iotests/147 | 5 ++---
 tests/qemu-iotests/205 | 3 ++-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
index 2d84fddb01..ab8480b9a4 100755
--- a/tests/qemu-iotests/147
+++ b/tests/qemu-iotests/147
@@ -287,6 +287,5 @@ class BuiltinNBD(NBDBlockdevAddBase):
 if __name__ == '__main__':
-    # Need to support image creation
-    iotests.main(supported_fmts=['vpc', 'parallels', 'qcow', 'vdi', 'qcow2',
-                                 'vmdk', 'raw', 'vhdx', 'qed'])
+    iotests.main(supported_fmts=['raw'],
+                 supported_protocols=['nbd'])
diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
index b8a86c446e..76f6c5fa2b 100755
--- a/tests/qemu-iotests/205
+++ b/tests/qemu-iotests/205
@@ -153,4 +153,5 @@ class TestNbdServerRemove(iotests.QMPTestCase):
 if __name__ == '__main__':
-    iotests.main(supported_fmts=['generic'])
+    iotests.main(supported_fmts=['raw'],
+                 supported_protocols=['nbd'])
generated by git-patchbot for /home/xen/git/qemu-xen.git#staging-4.13



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.