[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [qemu-xen stable-4.14] qdev: Fix device_add DRIVER,help to print to monitor
commit c16fd8a2bbf54a1d4fc599f6e88f69b8bbeecc28 Author: Markus Armbruster <armbru@xxxxxxxxxx> AuthorDate: Tue Jul 14 18:01:58 2020 +0200 Commit: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx> CommitDate: Wed Sep 2 19:06:19 2020 -0500 qdev: Fix device_add DRIVER,help to print to monitor Help on device properties gets printed to stdout instead of the monitor. If you have the monitor anywhere else, no help for you. Broken when commit e1043d674d "qdev: use object_property_help()" accidentally switched from qemu_printf() to printf(). Switch right back. Fixes: e1043d674d792ff64aebae1a3eafc08b38a8a085 Cc: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> Cc: qemu-stable@xxxxxxxxxx Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx> Message-Id: <20200714160202.3121879-2-armbru@xxxxxxxxxx> Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> Reviewed-by: Li Qiang <liq3ea@xxxxxxxxx> Reviewed-by: Dr. David Alan Gilbert <dgilbert@xxxxxxxxxx> (cherry picked from commit 029afc4e76041e1a320530d97f99122a1b3d5da2) Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx> --- qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 9833b33549..6bf6339ff5 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -299,7 +299,7 @@ int qdev_device_help(QemuOpts *opts) } g_ptr_array_sort(array, (GCompareFunc)qemu_pstrcmp0); for (i = 0; i < array->len; i++) { - printf("%s\n", (char *)array->pdata[i]); + qemu_printf("%s\n", (char *)array->pdata[i]); } g_ptr_array_set_free_func(array, g_free); g_ptr_array_free(array, true); -- generated by git-patchbot for /home/xen/git/qemu-xen.git#stable-4.14
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |