[qemu-xen staging] hw/avr/boot: Fix memory leak in avr_load_firmware()

[patchbot@xxxxxxx]

commit 5e29521a82e540552880c3572cb8274bcaa1002c
Author:     Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
AuthorDate: Tue Jul 14 18:15:05 2020 +0200
Commit:     Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
CommitDate: Tue Jul 21 16:13:04 2020 +0200

    hw/avr/boot: Fix memory leak in avr_load_firmware()
    
    The value returned by qemu_find_file() must be freed.
    
    This fixes Coverity issue CID 1430449, which points out
    that the memory returned by qemu_find_file() is leaked.
    
    Fixes: Coverity CID 1430449 (RESOURCE_LEAK)
    Fixes: 7dd8f6fde4 ('hw/avr: Add support for loading ELF/raw binaries')
    Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
    Reviewed-by: Michael Rolnik <mrolnik@xxxxxxxxx>
    Tested-by: Michael Rolnik <mrolnik@xxxxxxxxx>
    Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
    Message-Id: <20200714164257.23330-5-f4bug@xxxxxxxxx>
---
 hw/avr/boot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/avr/boot.c b/hw/avr/boot.c
index 6fbcde4061..d16bb3dbe1 100644
--- a/hw/avr/boot.c
+++ b/hw/avr/boot.c
@@ -60,7 +60,7 @@ static const char *avr_elf_e_flags_to_cpu_type(uint32_t flags)
 bool avr_load_firmware(AVRCPU *cpu, MachineState *ms,
                        MemoryRegion *program_mr, const char *firmware)
 {
-    const char *filename;
+    g_autofree char *filename = NULL;
     int bytes_loaded;
     uint64_t entry;
     uint32_t e_flags;
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#staging