[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen master] disas/sh4: Add missing fallthrough annotations



commit ccb237090fdafedce56cb8b62f451a09ad5031c9
Author:     Thomas Huth <thuth@xxxxxxxxxx>
AuthorDate: Tue Jun 30 07:03:44 2020 +0200
Commit:     Thomas Huth <thuth@xxxxxxxxxx>
CommitDate: Mon Jul 13 11:40:52 2020 +0200

    disas/sh4: Add missing fallthrough annotations
    
    Add fallthrough annotations to be able to compile the code without
    warnings with -Wimplicit-fallthrough. Looking at the code, it seems
    like the fallthrough is indeed intended here, so the comments should
    be appropriate.
    
    Message-Id: <20200630055953.9309-1-thuth@xxxxxxxxxx>
    Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx>
    Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
---
 disas/sh4.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/disas/sh4.c b/disas/sh4.c
index 55ef865a36..dcdbdf26d8 100644
--- a/disas/sh4.c
+++ b/disas/sh4.c
@@ -1963,6 +1963,7 @@ print_insn_sh (bfd_vma memaddr, struct disassemble_info 
*info)
                  fprintf_fn (stream, "xd%d", rn & ~1);
                  break;
                }
+             /* fallthrough */
            case D_REG_N:
              fprintf_fn (stream, "dr%d", rn);
              break;
@@ -1972,6 +1973,7 @@ print_insn_sh (bfd_vma memaddr, struct disassemble_info 
*info)
                  fprintf_fn (stream, "xd%d", rm & ~1);
                  break;
                }
+             /* fallthrough */
            case D_REG_M:
              fprintf_fn (stream, "dr%d", rm);
              break;
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.