[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen master] hw: Only compile the usb-dwc2 controller if it is really needed



commit 8d942986be27bb40e6faca2032af763d7db57082
Author:     Thomas Huth <thuth@xxxxxxxxxx>
AuthorDate: Wed Jul 22 17:47:19 2020 +0200
Commit:     Gerd Hoffmann <kraxel@xxxxxxxxxx>
CommitDate: Fri Jul 24 16:15:28 2020 +0200

    hw: Only compile the usb-dwc2 controller if it is really needed
    
    The USB_DWC2 switch is currently "default y", so it is included in all
    qemu-system-* builds, even if it is not needed. Even worse, it does a
    "select USB", so USB devices are now showing up as available on targets
    that do not support USB at all. This sysbus device should only be
    included by the boards that need it, i.e. by the Raspi machines.
    
    Fixes: 153ef1662c ("dwc-hsotg (dwc2) USB host controller emulation")
    Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
    Reviewed-by: Paul Zimmerman <pauldzim@xxxxxxxxx>
    Message-id: 20200722154719.10130-1-thuth@xxxxxxxxxx
    Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
---
 hw/arm/Kconfig | 1 +
 hw/usb/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 4a224a6351..bc3a423940 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -315,6 +315,7 @@ config RASPI
     select FRAMEBUFFER
     select PL011 # UART
     select SDHCI
+    select USB_DWC2
 
 config STM32F205_SOC
     bool
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index d4d8c37c28..5e63dc75f8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -48,7 +48,6 @@ config USB_MUSB
 
 config USB_DWC2
     bool
-    default y
     select USB
 
 config TUSB6010
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.