[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] x86/DMI: fix SMBIOS pointer range check



commit 6befe598706218673b14710d90d00ce90763b372
Author:     Jan Beulich <JBeulich@xxxxxxxx>
AuthorDate: Tue Nov 24 11:25:29 2020 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Nov 24 11:25:29 2020 +0100

    x86/DMI: fix SMBIOS pointer range check
    
    Forever since its introduction this has been using an inverted relation
    operator.
    
    Fixes: 54057a28f22b ("x86: support SMBIOS v3")
    Signed-off-by: Jan Beulich <JBeulich@xxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/dmi_scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c
index d24da1c53a..e5930d27ea 100644
--- a/xen/arch/x86/dmi_scan.c
+++ b/xen/arch/x86/dmi_scan.c
@@ -357,7 +357,7 @@ static int __init dmi_iterate(void (*decode)(struct 
dmi_header *))
                        memcpy_fromio(&smbios3, q, sizeof(smbios3));
                        if (memcmp(smbios3.anchor, "_SM3_", 5) ||
                            smbios3.length < sizeof(smbios3) ||
-                           q < p + 0x10000 - smbios3.length ||
+                           q > p + 0x10000 - smbios3.length ||
                            !dmi_checksum(q, smbios3.length))
                                smbios3.length = 0;
                }
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.