[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging-4.14] x86/vpt: fix build with old gcc

commit 7c6ee4ee232d2e7b2db1981aa7b9f578a2b0f0ad
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Dec 1 15:32:51 2020 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Dec 1 15:32:51 2020 +0100

    x86/vpt: fix build with old gcc
    I believe it was the XSA-336 fix (42fcdd42328f "x86/vpt: fix race when
    migrating timers between vCPUs") which has unmasked a bogus
    uninitialized variable warning. This is observable with gcc 4.3.4, but
    only on 4.13 and older; it's hidden on newer versions apparently due to
    the addition to _read_unlock() done by 12509bbeb9e3 ("rwlocks: call
    preempt_disable() when taking a rwlock").
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    master commit: f2c620aa062767b318267d678ae249dcb637b870
    master date: 2020-11-18 12:38:01 +0100
 xen/arch/x86/hvm/vpt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c
index d64467b631..ae7f715620 100644
--- a/xen/arch/x86/hvm/vpt.c
+++ b/xen/arch/x86/hvm/vpt.c
@@ -401,7 +401,7 @@ int pt_update_irq(struct vcpu *v)
                  * associated with the timer.
                 time_cb *cb = NULL;
-                void *cb_priv;
+                void *cb_priv = NULL;
                 /* Make sure the timer is still on the list. */
generated by git-patchbot for /home/xen/git/xen.git#staging-4.14



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.