[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] xen/arm: mm: Remove special case for CPU0 in dump_hyp_walk()

commit d90390d031554337f4fc9c98045d5a9ef71e6f23
Author:     Stefano Stabellini <sstabellini@xxxxxxxxxx>
AuthorDate: Thu Nov 19 19:07:46 2020 +0000
Commit:     Julien Grall <jgrall@xxxxxxxxxx>
CommitDate: Sat Jan 23 11:41:29 2021 +0000

    xen/arm: mm: Remove special case for CPU0 in dump_hyp_walk()
    There is no need to have a special case for CPU0 when converting the
    page-table virtual address into a physical address. The helper
    virt_to_maddr() is able to translate any address as long as the root
    page-tables is mapped in the virtual address. This is the case for all
    the CPUs at the moment.
    So use the same BUG_ON() regardless the CPU.
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
    [julien: Rework the commit message]
    Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
 xen/arch/arm/mm.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 9c4b26bf07..4dd886f7c8 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -284,10 +284,7 @@ void dump_hyp_walk(vaddr_t addr)
            "on CPU%d via TTBR 0x%016"PRIx64"\n",
            addr, smp_processor_id(), ttbr);
-    if ( smp_processor_id() == 0 )
-        BUG_ON( (lpae_t *)(unsigned long)(ttbr - phys_offset) != pgtable );
-    else
-        BUG_ON( virt_to_maddr(pgtable) != ttbr );
+    BUG_ON( virt_to_maddr(pgtable) != ttbr );
     dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1);
generated by git-patchbot for /home/xen/git/xen.git#master



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.