[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] tools/libs: Fix headers.chk logic

commit 9e23f10eb0db5ffa06f1a43f74fac790992a85c7
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Thu Mar 4 22:30:00 2021 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Thu Mar 11 17:27:48 2021 +0000

    tools/libs: Fix headers.chk logic
    c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.chk
    rule, without replacing it.
    As headers.chk uses $^, a typical build looks like:
      andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel/
      make: Entering directory '/local/xen.git/tools/libs/devicemodel'
      for i in ; do \
          gcc -x c -ansi -Wall -Werror 
-I/local/xen.git/tools/libs/devicemodel/../../../tools/include \
                -S -o /dev/null $i || exit 1; \
          echo $i; \
      done >headers.chk.new
      mv headers.chk.new headers.chk
    i.e. with an empty for loop.
    Reinsert a $(LIBHEADERS) dependency, so more than just the $(AUTOINCS) get
    Fixes: 4664034cd ("tools/libs: move official headers to common directory")
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
    Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
 tools/libs/libs.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index a68cec244c..2d973ccb95 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -76,7 +76,7 @@ else
 .PHONY: headers.chk
-headers.chk: $(AUTOINCS)
+headers.chk: $(LIBHEADERS) $(AUTOINCS)
 headers.lst: FORCE
        @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp
generated by git-patchbot for /home/xen/git/xen.git#master



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.