[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] tools/kdd: Use const whenever we point to literal strings
commit 922dcbab0b465f9da006b31da1a61e93734a080e Author: Julien Grall <jgrall@xxxxxxxxxx> AuthorDate: Tue Apr 6 19:59:25 2021 +0100 Commit: Julien Grall <jgrall@xxxxxxxxxx> CommitDate: Tue Apr 6 20:03:10 2021 +0100 tools/kdd: Use const whenever we point to literal strings literal strings are not meant to be modified. So we should use const char * rather than char * when we want to shore a pointer to them. Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx> Acked-by: Tim Deegan <tim@xxxxxxx> --- tools/debugger/kdd/kdd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/kdd/kdd.c index a7d0976ea4..17513c2650 100644 --- a/tools/debugger/kdd/kdd.c +++ b/tools/debugger/kdd/kdd.c @@ -67,7 +67,7 @@ typedef struct { uint32_t build; int w64; int mp; - char *name; + const char *name; uint64_t base; /* KernBase: start looking here */ uint32_t range; /* | and search an area this size */ uint32_t version; /* +-> NtBuildNumber */ @@ -237,7 +237,7 @@ static size_t blocking_write(int fd, const void *buf, size_t count) } /* Dump the contents of a complete serial packet into a log file. */ -static void kdd_log_pkt(kdd_state *s, char *name, kdd_pkt *p) +static void kdd_log_pkt(kdd_state *s, const char *name, kdd_pkt *p) { uint32_t sum = 0; unsigned int i, j; @@ -504,8 +504,8 @@ static int check_os(kdd_state *s) * @return -1 on failure to find the section name * @return 0 on success */ -static int get_pe64_sections(kdd_state *s, uint64_t filebase, char *sectname, - uint64_t *vaddr, uint32_t *vsize) +static int get_pe64_sections(kdd_state *s, uint64_t filebase, + const char *sectname, uint64_t *vaddr, uint32_t *vsize) { uint64_t pe_hdr = 0; uint64_t sect_start = 0; @@ -781,7 +781,7 @@ static void kdd_send_cmd(kdd_state *s, uint32_t subtype, size_t extra) } /* Cause the client to print a string */ -static void kdd_send_string(kdd_state *s, char *fmt, ...) +static void kdd_send_string(kdd_state *s, const char *fmt, ...) { uint32_t len = 0xffff - sizeof (kdd_msg); char *buf = (char *) s->txb + sizeof (kdd_hdr) + sizeof (kdd_msg); -- generated by git-patchbot for /home/xen/git/xen.git#master
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |