[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] x86/HVM: avoid effectively open-coding xzalloc_flex_struct()
commit 23eda45f12ec98638d0175b615d3bc3428fd2eda Author: Jan Beulich <jbeulich@xxxxxxxx> AuthorDate: Fri Apr 9 09:24:23 2021 +0200 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Fri Apr 9 09:24:23 2021 +0200 x86/HVM: avoid effectively open-coding xzalloc_flex_struct() Drop hvm_irq_size(), which exists for just this purpose. There is a difference in generated code: xzalloc_bytes() forces SMP_CACHE_BYTES alignment. I think we not only don't need this here, but actually don't want it. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> --- xen/arch/x86/hvm/hvm.c | 3 ++- xen/include/asm-x86/hvm/irq.h | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index e7bcffebc4..ae37bc434a 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -642,7 +642,8 @@ int hvm_domain_initialise(struct domain *d) d->arch.hvm.params = xzalloc_array(uint64_t, HVM_NR_PARAMS); d->arch.hvm.io_handler = xzalloc_array(struct hvm_io_handler, NR_IO_HANDLERS); - d->arch.hvm.irq = xzalloc_bytes(hvm_irq_size(nr_gsis)); + d->arch.hvm.irq = xzalloc_flex_struct(struct hvm_irq, + gsi_assert_count, nr_gsis); rc = -ENOMEM; if ( !d->arch.hvm.pl_time || !d->arch.hvm.irq || diff --git a/xen/include/asm-x86/hvm/irq.h b/xen/include/asm-x86/hvm/irq.h index 7f76f6c437..717c2299de 100644 --- a/xen/include/asm-x86/hvm/irq.h +++ b/xen/include/asm-x86/hvm/irq.h @@ -98,7 +98,6 @@ struct hvm_irq { #define hvm_pci_intx_link(dev, intx) \ (((dev) + (intx)) & 3) #define hvm_domain_irq(d) ((d)->arch.hvm.irq) -#define hvm_irq_size(cnt) offsetof(struct hvm_irq, gsi_assert_count[cnt]) #define hvm_isa_irq_to_gsi(isa_irq) ((isa_irq) ? : 2) -- generated by git-patchbot for /home/xen/git/xen.git#master
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |