[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] hypfs: avoid effectively open-coding xzalloc_array()
commit ca68c70d30d68a671a45789a85f8ace6d8360334 Author: Jan Beulich <jbeulich@xxxxxxxx> AuthorDate: Fri Apr 9 09:25:42 2021 +0200 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Fri Apr 9 09:25:42 2021 +0200 hypfs: avoid effectively open-coding xzalloc_array() There is a difference in generated code: xzalloc_bytes() forces SMP_CACHE_BYTES alignment. I think we not only don't need this here, but actually don't want it. To avoid the need to add a cast, do away with the only forward-declared struct hypfs_dyndata. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Juergen Gross <jgross@xxxxxxxx> --- xen/common/hypfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/common/hypfs.c b/xen/common/hypfs.c index 5468497404..e71f7df479 100644 --- a/xen/common/hypfs.c +++ b/xen/common/hypfs.c @@ -72,7 +72,7 @@ enum hypfs_lock_state { hypfs_write_locked }; static DEFINE_PER_CPU(enum hypfs_lock_state, hypfs_locked); -static DEFINE_PER_CPU(struct hypfs_dyndata *, hypfs_dyndata); +static DEFINE_PER_CPU(void *, hypfs_dyndata); static DEFINE_PER_CPU(const struct hypfs_entry *, hypfs_last_node_entered); @@ -160,19 +160,19 @@ static void node_exit_all(void) void *hypfs_alloc_dyndata(unsigned long size) { unsigned int cpu = smp_processor_id(); - struct hypfs_dyndata **dyndata = &per_cpu(hypfs_dyndata, cpu); + void **dyndata = &per_cpu(hypfs_dyndata, cpu); ASSERT(per_cpu(hypfs_locked, cpu) != hypfs_unlocked); ASSERT(*dyndata == NULL); - *dyndata = xzalloc_bytes(size); + *dyndata = xzalloc_array(unsigned char, size); return *dyndata; } void *hypfs_get_dyndata(void) { - struct hypfs_dyndata *dyndata = this_cpu(hypfs_dyndata); + void *dyndata = this_cpu(hypfs_dyndata); ASSERT(dyndata); @@ -181,7 +181,7 @@ void *hypfs_get_dyndata(void) void hypfs_free_dyndata(void) { - struct hypfs_dyndata **dyndata = &this_cpu(hypfs_dyndata); + void **dyndata = &this_cpu(hypfs_dyndata); XFREE(*dyndata); } -- generated by git-patchbot for /home/xen/git/xen.git#master
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |