[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen staging] tools/top: The string parameter in set_prompt() and set_delay() should be const
commit 4b7702727a8d89fea0a239adcbeb18aa2c85ede0 Author: Julien Grall <jgrall@xxxxxxxxxx> AuthorDate: Tue May 18 14:51:28 2021 +0100 Commit: Julien Grall <jgrall@xxxxxxxxxx> CommitDate: Tue May 18 14:54:05 2021 +0100 tools/top: The string parameter in set_prompt() and set_delay() should be const Neither string parameter in set_prompt() and set_delay() are meant to be modified. In particular, new_prompt can point to a literal string. So mark the two parameters as const and propagate it. Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Acked-by: Wei Liu <wl@xxxxxxx> --- tools/xentop/xentop.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c index ebed070c0f..950e8935c4 100644 --- a/tools/xentop/xentop.c +++ b/tools/xentop/xentop.c @@ -81,8 +81,8 @@ static int current_row(void); static int lines(void); static void print(const char *, ...) __attribute__((format(printf,1,2))); static void attr_addstr(int attr, const char *str); -static void set_delay(char *value); -static void set_prompt(char *new_prompt, void (*func)(char *)); +static void set_delay(const char *value); +static void set_prompt(const char *new_prompt, void (*func)(const char *)); static int handle_key(int); static int compare(unsigned long long, unsigned long long); static int compare_domains(xenstat_domain **, xenstat_domain **); @@ -212,10 +212,10 @@ int show_vbds = 0; int repeat_header = 0; int show_full_name = 0; #define PROMPT_VAL_LEN 80 -char *prompt = NULL; +const char *prompt = NULL; char prompt_val[PROMPT_VAL_LEN]; int prompt_val_len = 0; -void (*prompt_complete_func)(char *); +void (*prompt_complete_func)(const char *); static WINDOW *cwin; @@ -331,7 +331,7 @@ static void attr_addstr(int attr, const char *str) } /* Handle setting the delay from the user-supplied value in prompt_val */ -static void set_delay(char *value) +static void set_delay(const char *value) { int new_delay; new_delay = atoi(value); @@ -341,7 +341,7 @@ static void set_delay(char *value) /* Enable prompting mode with the given prompt string; call the given function * when a value is available. */ -static void set_prompt(char *new_prompt, void (*func)(char *)) +static void set_prompt(const char *new_prompt, void (*func)(const char *)) { prompt = new_prompt; prompt_val[0] = '\0'; -- generated by git-patchbot for /home/xen/git/xen.git#staging
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |