[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] xen/arm32: avoid .rodata to be marked as executable

commit 163f47c14737cfa9dfb3240deea356b08caf7614
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Fri Jun 11 11:19:15 2021 +0200
Commit:     Julien Grall <jgrall@xxxxxxxxxx>
CommitDate: Mon Jun 14 14:14:11 2021 +0100

    xen/arm32: avoid .rodata to be marked as executable
    The section .proc.info lives in .rodata as it doesn't contain any
    executable code. However, the section is still marked as executable
    as the consequence .rodata will also be marked executable.
    Xen doesn't use the ELF permissions to decide the page-table mapping
    permission. However, this will confuse disassemblers.
    '#execinstr' is now removed on all the pushsection dealing with
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    [julieng: Rework the commit message]
    Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
 xen/arch/arm/arm32/proc-v7.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
index 1efde2d72d..c90a31d80f 100644
--- a/xen/arch/arm/arm32/proc-v7.S
+++ b/xen/arch/arm/arm32/proc-v7.S
@@ -29,7 +29,7 @@ brahma15mp_init:
         mcr   CP32(r0, ACTLR)
         mov   pc, lr
-        .section ".proc.info", #alloc, #execinstr
+        .section ".proc.info", #alloc
         .type __v7_ca15mp_proc_info, #object
         .long 0x410FC0F0             /* Cortex-A15 */
@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
         .long caxx_processor
         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
-        .section ".proc.info", #alloc, #execinstr
+        .section ".proc.info", #alloc
         .type __v7_ca7mp_proc_info, #object
         .long 0x410FC070             /* Cortex-A7 */
@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
         .long caxx_processor
         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
-        .section ".proc.info", #alloc, #execinstr
+        .section ".proc.info", #alloc
         .type __v7_brahma15mp_proc_info, #object
         .long 0x420F00F0             /* Broadcom Brahma-B15 */
generated by git-patchbot for /home/xen/git/xen.git#master



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.