[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen staging] tools/xenstored: xenstored_core.h should include fcntl.h
commit a8002238b49c3423c7081dfbac3580651f5242ef Author: Julien Grall <jgrall@xxxxxxxxxx> AuthorDate: Thu Jun 24 09:07:52 2021 +0100 Commit: Julien Grall <jgrall@xxxxxxxxxx> CommitDate: Thu Jun 24 09:07:52 2021 +0100 tools/xenstored: xenstored_core.h should include fcntl.h xenstored_core.h will consider live-udpate is not supported if O_CLOEXEC doesn't exist. However, the header doesn't include the one defining O_CLOEXEC (i.e. fcntl.h). This means that depending on the header included, some source file will think Live-Update is not supported. I am not aware of any issue with the existing. Therefore this is just a latent bug so far. Prevent any potential issue by including fcntl.h in xenstored_core.h Fixes: cd831ee438 ("tools/xenstore: handle CLOEXEC flag for local files and pipes") Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx> Reviewed-by: Juergen Gross <jgross@xxxxxxxx> --- tools/xenstore/xenstored_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 34839b34f6..dac5171569 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -24,6 +24,7 @@ #include <sys/types.h> #include <dirent.h> +#include <fcntl.h> #include <stdbool.h> #include <stdint.h> #include <errno.h> -- generated by git-patchbot for /home/xen/git/xen.git#staging
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |