[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] tools/xenstored: Remove redundant check in socket_can_process()

commit e87d8f60fa9b6eaa6a2357545a96e4fff05dbef0
Author:     Julien Grall <jgrall@xxxxxxxxxx>
AuthorDate: Thu Jun 24 15:55:03 2021 +0100
Commit:     Julien Grall <jgrall@xxxxxxxxxx>
CommitDate: Thu Jun 24 15:55:49 2021 +0100

    tools/xenstored: Remove redundant check in socket_can_process()
    Commit 3adfb50315d9 ("tools/xenstored: Introduce a wrapper for
    conn->funcs->can_{read, write}") consolidated the check
    !conn->is_ignored in two new wrappers.
    This means the check in socket_can_process() is now redundant. In
    fact it should have been removed in orignal commit (as it was done
    for the domain helpers).
    Reported-by: Raphael Ning <raphning@xxxxxxxxxx
    Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
    Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
 tools/xenstore/xenstored_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 9ffd2ac66d..cf7297a96c 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1752,7 +1752,7 @@ static bool socket_can_process(struct connection *conn, 
int mask)
                return false;
-       return (fds[conn->pollfd_idx].revents & mask) && !conn->is_ignored;
+       return (fds[conn->pollfd_idx].revents & mask);
 static bool socket_can_write(struct connection *conn)
generated by git-patchbot for /home/xen/git/xen.git#master



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.