[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] ns16550: properly gate Exar PCIe UART cards support

commit 93713f444b3f29d6848527506db69cf78976b32d
Author:     Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
AuthorDate: Fri Aug 20 16:18:12 2021 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Aug 20 16:18:12 2021 +0200

    ns16550: properly gate Exar PCIe UART cards support
    Arm is about to get PCI passthrough support which means CONFIG_HAS_PCI
    will be enabled, so this code will fail as Arm doesn't have ns16550
    PCI support:
    ns16550.c:313:5: error: implicit declaration of function 
'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration]
      313 |     enable_exar_enhanced_bits(uart);
          |     ^~~~~~~~~~~~~~~~~~~~~~~~~
    Fix this by gating Exar PCIe UART cards support with the above in mind.
    Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
 xen/drivers/char/ns16550.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index b777c8711e..e2c24082c3 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
     /* Handle the DesignWare 8250 'busy-detect' quirk. */
+#ifdef NS16550_PCI
     /* Enable Exar "Enhanced function bits" */
generated by git-patchbot for /home/xen/git/xen.git#staging



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.