[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] domain: try to address Coverity pointing out a missing "break" in domain_teardown()

commit 7429e08d9c1cabec3ce1c7c246fb711f6e225275
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Sep 8 14:38:33 2021 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Sep 8 14:38:33 2021 +0200

    domain: try to address Coverity pointing out a missing "break" in 
    Commit 806448806264 ("xen/domain: Fix label position in
    domain_teardown()" has caused Coverity to report a _new_ supposedly
    un-annotated fall-through in a switch(). I find this (once again)
    puzzling; I'm having an increasingly hard time figuring what patterns
    the tool is actually after. I would have expected that the tool would
    either have spotted an issue also before this change, or not at all. Yet
    if it had spotted one before, the statistics report should have included
    an eliminated instance alongside the new one (because then the issue
    would simply have moved by a few lines).
    Hence the only thing I could guess is that the treatment of comments in
    macro expansions might be subtly different. Therefore try whether
    switching the comments to the still relatively new "fallthrough" pseudo
    keyword actually helps.
    Coverity-ID: 1490865
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
    Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
 xen/common/domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 0d3385ad5a..6ee5d033b0 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -401,13 +401,13 @@ static int domain_teardown(struct domain *d)
 #define PROGRESS(x)                             \
         d->teardown.val = PROG_ ## x;           \
-        /* Fallthrough */                       \
+        fallthrough;                            \
     case PROG_ ## x
 #define PROGRESS_VCPU(x)                        \
         d->teardown.val = PROG_vcpu_ ## x;      \
         d->teardown.vcpu = v;                   \
-        /* Fallthrough */                       \
+        fallthrough;                            \
     case PROG_vcpu_ ## x:                       \
         v = d->teardown.vcpu
generated by git-patchbot for /home/xen/git/xen.git#master



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.