[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] x86: quote section names when defining them in linker script

commit 6254920587c33bcc7ab884e6c9a11cfc0d5867ab
Author:     Roger Pau Monné <roger.pau@xxxxxxxxxx>
AuthorDate: Wed Sep 15 11:02:21 2021 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Sep 15 11:02:21 2021 +0200

    x86: quote section names when defining them in linker script
    LLVM ld seems to require section names to be quoted at both definition
    and when referencing them for a match to happen, or else we get the
    following errors:
    ld: error: xen.lds:45: undefined section ".text"
    ld: error: xen.lds:69: undefined section ".rodata"
    ld: error: xen.lds:104: undefined section ".note.gnu.build-id"
    The original fix for GNU ld 2.37 only quoted the section name when
    referencing it in the ADDR function. Fix by also quoting the section
    names when declaring them.
    Fixes: 58ad654ebce7 ("x86: work around build issue with GNU ld 2.37")
    Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
 xen/arch/x86/xen.lds.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 955d5cf4a0..11b1da2154 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -18,7 +18,7 @@ ENTRY(efi_start)
 #else /* !EFI */
 #define FORMAT "elf64-x86-64"
-#define DECL_SECTION(x) x : AT(ADDR(#x) - __XEN_VIRT_START)
+#define DECL_SECTION(x) #x : AT(ADDR(#x) - __XEN_VIRT_START)
generated by git-patchbot for /home/xen/git/xen.git#master



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.