[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] tools/flask/utils: remove unused variables/targets from Makefile



commit c1634f0c86095e22228a1e1f6f917bfe1c91001d
Author:     Anthony PERARD <anthony.perard@xxxxxxxxxx>
AuthorDate: Mon Dec 6 17:01:57 2021 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Thu Dec 16 20:27:12 2021 +0000

    tools/flask/utils: remove unused variables/targets from Makefile
    
    They are no *.opic or *.so in this subdir, so no need to clean them.
    
    The TEST* variables doesn't seems to be used anywhere, and they weren't
    used by xen.git when introduced.
    Both CLIENTS_* variables aren't used.
    Both target "print-dir" and "print-end" only exist in this directory
    and are probably not used anywhere.
    
    Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
    [Drop trailing whitespace and use $(RM) consistently]
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 tools/flask/utils/Makefile | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/tools/flask/utils/Makefile b/tools/flask/utils/Makefile
index ae87102144..db567b13dc 100644
--- a/tools/flask/utils/Makefile
+++ b/tools/flask/utils/Makefile
@@ -4,13 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenctrl)
 
-TESTDIR  = testsuite/tmp
-TESTFLAGS= -DTESTING
-TESTENV  = XENSTORED_ROOTDIR=$(TESTDIR) XENSTORED_RUNDIR=$(TESTDIR)
-
 CLIENTS := flask-loadpolicy flask-setenforce flask-getenforce flask-label-pci 
flask-get-bool flask-set-bool
-CLIENTS_SRCS := $(patsubst flask-%,%.c,$(CLIENTS))
-CLIENTS_OBJS := $(patsubst flask-%,%.o,$(CLIENTS))
 
 .PHONY: all
 all: $(CLIENTS)
@@ -34,22 +28,12 @@ flask-set-bool: set-bool.o
        $(CC) $(LDFLAGS) $< $(LDLIBS) $(LDLIBS_libxenctrl) -o $@
 
 .PHONY: clean
-clean: 
-       rm -f *.o *.opic *.so
-       rm -f $(CLIENTS)
-       $(RM) $(DEPS_RM)
+clean:
+       $(RM) *.o $(CLIENTS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
 
-.PHONY: print-dir
-print-dir:
-       @echo -n tools/flask/utils: 
-
-.PHONY: print-end
-print-end:
-       @echo
-
 .PHONY: install
 install: all
        $(INSTALL_DIR) $(DESTDIR)$(sbindir)
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.