[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen stable-4.16] hw/i386: Rename default_bus_bypass_iommu



commit 5cf977a2a18a0f6c92b36e852639f26b993d76e5
Author:     Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
AuthorDate: Mon Oct 25 11:47:38 2021 +0100
Commit:     Michael Roth <michael.roth@xxxxxxx>
CommitDate: Tue Dec 14 13:07:48 2021 -0600

    hw/i386: Rename default_bus_bypass_iommu
    
    Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
    parameter definitions cannot use underscores, because keyval_dashify()
    transforms them to dashes and the parser doesn't find the parameter.
    
    This affects option default_bus_bypass_iommu which was introduced in the
    same release:
    
    $ qemu-system-x86_64 -M q35,default_bus_bypass_iommu=on
    qemu-system-x86_64: Property 'pc-q35-6.1-machine.default-bus-bypass-iommu' 
not found
    
    Rename the parameter to "default-bus-bypass-iommu". Passing
    "default_bus_bypass_iommu" is still valid since the underscore are
    transformed automatically.
    
    Fixes: c9e96b04fc19 ("hw/i386: Add a default_bus_bypass_iommu pc machine 
option")
    Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx>
    Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
    Tested-by: Eric Auger <eric.auger@xxxxxxxxxx>
    Signed-off-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
    Message-Id: <20211025104737.1560274-1-jean-philippe@xxxxxxxxxx>
    Cc: qemu-stable@xxxxxxxxxx
    Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
    (cherry picked from commit 739b38630c45585cd9d372d44537f69c0b2b4346)
    Signed-off-by: Michael Roth <michael.roth@xxxxxxx>
---
 hw/i386/pc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index c2b9d62a35..1d421ae2f8 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1763,7 +1763,7 @@ static void pc_machine_class_init(ObjectClass *oc, void 
*data)
     object_class_property_add_bool(oc, "hpet",
         pc_machine_get_hpet, pc_machine_set_hpet);
 
-    object_class_property_add_bool(oc, "default_bus_bypass_iommu",
+    object_class_property_add_bool(oc, "default-bus-bypass-iommu",
         pc_machine_get_default_bus_bypass_iommu,
         pc_machine_set_default_bus_bypass_iommu);
 
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#stable-4.16



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.