[qemu-xen stable-4.16] hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196

[patchbot@xxxxxxx]

commit 71ba2adfeb4ca63015d4a51a665e67c46a06e822
Author:     Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
AuthorDate: Wed Nov 24 17:15:35 2021 +0100
Commit:     Michael Roth <michael.roth@xxxxxxx>
CommitDate: Tue Dec 14 15:05:05 2021 -0600

    hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196
    
    Guest might select another drive on the bus by setting the
    DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR).
    The current controller model doesn't expect a BlockBackend
    to be NULL. A simple way to fix CVE-2021-20196 is to create
    an empty BlockBackend when it is missing. All further
    accesses will be safely handled, and the controller state
    machines keep behaving correctly.
    
    Cc: qemu-stable@xxxxxxxxxx
    Fixes: CVE-2021-20196
    Reported-by: Gaoning Pan (Ant Security Light-Year Lab) <pgn@xxxxxxxxxx>
    Reviewed-by: Darren Kenny <darren.kenny@xxxxxxxxxx>
    Reviewed-by: Hanna Reitz <hreitz@xxxxxxxxxx>
    Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
    Message-id: 20211124161536.631563-3-philmd@xxxxxxxxxx
    BugLink: https://bugs.launchpad.net/qemu/+bug/1912780
    Resolves: https://gitlab.com/qemu-project/qemu/-/issues/338
    Reviewed-by: Darren Kenny <darren.kenny@xxxxxxxxxx>
    Reviewed-by: Hanna Reitz <hreitz@xxxxxxxxxx>
    Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
    Signed-off-by: John Snow <jsnow@xxxxxxxxxx>
    (cherry picked from commit 1ab95af033a419e7a64e2d58e67dd96b20af5233)
    Signed-off-by: Michael Roth <michael.roth@xxxxxxx>
---
 hw/block/fdc.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index c3e09973ca..af398c1116 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -1166,7 +1166,19 @@ static FDrive *get_drv(FDCtrl *fdctrl, int unit)
 
 static FDrive *get_cur_drv(FDCtrl *fdctrl)
 {
-    return get_drv(fdctrl, fdctrl->cur_drv);
+    FDrive *cur_drv = get_drv(fdctrl, fdctrl->cur_drv);
+
+    if (!cur_drv->blk) {
+        /*
+         * Kludge: empty drive line selected. Create an anonymous
+         * BlockBackend to avoid NULL deref with various BlockBackend
+         * API calls within this model (CVE-2021-20196).
+         * Due to the controller QOM model limitations, we don't
+         * attach the created to the controller device.
+         */
+        cur_drv->blk = blk_create_empty_drive();
+    }
+    return cur_drv;
 }
 
 /* Status A register : 0x00 (read-only) */
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#stable-4.16