[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen stable-4.16] qxl: fix pre-save logic



commit 34833f361b1407ad7b4f02ed5eb852e76ab032e4
Author:     Gerd Hoffmann <kraxel@xxxxxxxxxx>
AuthorDate: Fri Sep 10 11:42:03 2021 +0200
Commit:     Michael Roth <michael.roth@xxxxxxx>
CommitDate: Wed Dec 15 07:13:12 2021 -0600

    qxl: fix pre-save logic
    
    Oops.  Logic is backwards.
    
    Fixes: 39b8a183e2f3 ("qxl: remove assert in qxl_pre_save.")
    Resolves: https://gitlab.com/qemu-project/qemu/-/issues/610
    Resolves: https://bugzilla.redhat.com//show_bug.cgi?id=2002907
    Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
    Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
    Message-Id: <20210910094203.3582378-1-kraxel@xxxxxxxxxx>
    (cherry picked from commit eb94846280df3f1e2a91b6179fc05f9890b7e384)
    Signed-off-by: Michael Roth <michael.roth@xxxxxxx>
---
 hw/display/qxl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 43482d4364..29c80b4289 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -2252,7 +2252,7 @@ static int qxl_pre_save(void *opaque)
     } else {
         d->last_release_offset = (uint8_t *)d->last_release - ram_start;
     }
-    if (d->last_release_offset < d->vga.vram_size) {
+    if (d->last_release_offset >= d->vga.vram_size) {
         return 1;
     }
 
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#stable-4.16



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.