[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] video/vesa: drop "vesa-remap" command line option
commit 7f7e55b85fce2155d83dedabd6537b47e2ea0ec7 Author: Jan Beulich <jbeulich@xxxxxxxx> AuthorDate: Fri Feb 18 14:45:45 2022 +0100 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Fri Feb 18 14:45:45 2022 +0100 video/vesa: drop "vesa-remap" command line option If we get mode dimensions wrong, having the remapping size controllable via command line option isn't going to help much. Drop the option. While adjusting this also - add __initdata to the variable, - use ROUNDUP() instead of open-coding it. Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> --- CHANGELOG.md | 2 +- docs/misc/xen-command-line.pandoc | 3 --- xen/drivers/video/vesa.c | 11 +++-------- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f596eac3e..83d85fad5b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD ### Removed / support downgraded - - dropped support for the (x86-only) "vesa-mtrr" command line option + - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options ## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02 diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index a64aa5e841..ba5164eb64 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2489,9 +2489,6 @@ PCPUs when using the credit1 scheduler. This prevents rapid fluttering of a VCPU between CPUs, and reduces the implicit overheads such as cache-warming. 1ms (1000) has been measured as a good value. -### vesa-map -> `= <integer>` - ### vesa-ram > `= <integer>` diff --git a/xen/drivers/video/vesa.c b/xen/drivers/video/vesa.c index 5cc37f0171..8ff1b1d4ea 100644 --- a/xen/drivers/video/vesa.c +++ b/xen/drivers/video/vesa.c @@ -26,8 +26,7 @@ static bool_t vga_compat; static unsigned int vram_total; integer_param("vesa-ram", vram_total); -static unsigned int vram_remap; -integer_param("vesa-map", vram_remap); +static unsigned int __initdata vram_remap; static int font_height; static int __init parse_font_height(const char *s) @@ -79,12 +78,8 @@ void __init vesa_early_init(void) * use for vesafb. With modern cards it is no * option to simply use vram_total as that * wastes plenty of kernel address space. */ - vram_remap = (vram_remap ? - (vram_remap << 20) : - ((vram_vmode + (1 << L2_PAGETABLE_SHIFT) - 1) & - ~((1 << L2_PAGETABLE_SHIFT) - 1))); - vram_remap = max_t(unsigned int, vram_remap, vram_vmode); - vram_remap = min_t(unsigned int, vram_remap, vram_total); + vram_remap = ROUNDUP(vram_vmode, 1 << L2_PAGETABLE_SHIFT); + vram_remap = min(vram_remap, vram_total); } void __init vesa_init(void) -- generated by git-patchbot for /home/xen/git/xen.git#master
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |