[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] xen/mm: Remove always true ASSERT() in free_heap_pages()



commit f1097988b9baeb4cae38a1a71e027794291213ff
Author:     Julien Grall <jgrall@xxxxxxxxxx>
AuthorDate: Wed Feb 23 18:38:31 2022 +0000
Commit:     Julien Grall <jgrall@xxxxxxxxxx>
CommitDate: Thu Feb 24 14:57:55 2022 +0000

    xen/mm: Remove always true ASSERT() in free_heap_pages()
    
    free_heap_pages() has an ASSERT() checking that node is >= 0. However
    node is defined as an unsigned int. So it cannot be negative.
    
    Therefore remove the check as it will always be true.
    
    Coverity-ID: 1055631
    Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
    Acked-by: Andrew Cooper 
<andrew.cooper3@xxxxxxxxxx><mailto:andrew.cooper3@xxxxxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/common/page_alloc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 4635718237..e971bf91e0 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1441,7 +1441,6 @@ static void free_heap_pages(
     unsigned int zone = page_to_zone(pg);
 
     ASSERT(order <= MAX_ORDER);
-    ASSERT(node >= 0);
 
     spin_lock(&heap_lock);
 
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.