[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] platforms/xgene: Make use of dt_device_get_address return value



commit 1afe55905427b7e25936388c65a29c2bbb280bc8
Author:     Michal Orzel <michal.orzel@xxxxxxx>
AuthorDate: Wed Apr 27 11:49:39 2022 +0200
Commit:     Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
CommitDate: Wed Apr 27 15:23:09 2022 -0700

    platforms/xgene: Make use of dt_device_get_address return value
    
    Currently function xgene_check_pirq_eoi assigns the return value of
    dt_device_get_address to a variable res but does not make use of it.
    Fix it by making use of res in the condition checking the result of a
    call to dt_device_get_address instead of checking the address stored in
    dbase.
    
    Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
    Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
---
 xen/arch/arm/platforms/xgene-storm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/platforms/xgene-storm.c 
b/xen/arch/arm/platforms/xgene-storm.c
index fced4d7c2c..befd0c3c2d 100644
--- a/xen/arch/arm/platforms/xgene-storm.c
+++ b/xen/arch/arm/platforms/xgene-storm.c
@@ -51,7 +51,7 @@ static void __init xgene_check_pirq_eoi(void)
         panic("%s: Can not find interrupt controller node\n", __func__);
 
     res = dt_device_get_address(node, 0, &dbase, NULL);
-    if ( !dbase )
+    if ( res )
         panic("%s: Cannot find a valid address for the distributor\n", 
__func__);
 
     /*
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.