[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] tools/xenstore: don't let special watches be children of /



commit c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc
Author:     Juergen Gross <jgross@xxxxxxxx>
AuthorDate: Mon May 2 12:07:22 2022 +0200
Commit:     Julien Grall <jgrall@xxxxxxxxxx>
CommitDate: Thu May 5 11:58:47 2022 +0100

    tools/xenstore: don't let special watches be children of /
    
    When firing special watches (e.g. "@releaseDomain"), they will be
    regarded to be valid children of the "/" node. So a domain having
    registered a watch for "/" and having the privilege to receive
    the special watches will receive those special watch events for the
    registered "/" watch.
    
    Fix that by calling the related fire_watches() with the "exact"
    parameter set to true, causing a mismatch for the "/" node.
    
    Reported-by: Raphael Ning <raphning@xxxxxxxxxx>
    Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
    Reviewed-by: Raphael Ning <raphning@xxxxxxxxxx>
    Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
---
 tools/xenstore/xenstored_domain.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/xenstore/xenstored_domain.c 
b/tools/xenstore/xenstored_domain.c
index ae065fcbee..80ba1d627b 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -231,7 +231,7 @@ static int destroy_domain(void *_domain)
                        unmap_interface(domain->interface);
        }
 
-       fire_watches(NULL, domain, "@releaseDomain", NULL, false, NULL);
+       fire_watches(NULL, domain, "@releaseDomain", NULL, true, NULL);
 
        wrl_domain_destroy(domain);
 
@@ -282,7 +282,7 @@ void check_domains(void)
        }
 
        if (notify)
-               fire_watches(NULL, NULL, "@releaseDomain", NULL, false, NULL);
+               fire_watches(NULL, NULL, "@releaseDomain", NULL, true, NULL);
 }
 
 /* We scan all domains rather than use the information given here. */
@@ -495,7 +495,7 @@ static struct domain *introduce_domain(const void *ctx,
 
                if (!is_master_domain && !restore)
                        fire_watches(NULL, ctx, "@introduceDomain", NULL,
-                                    false, NULL);
+                                    true, NULL);
        } else {
                /* Use XS_INTRODUCE for recreating the xenbus event-channel. */
                if (domain->port)
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.