[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK



commit aa1cba100bff84b211f27639bd6efeaf7e701bcc
Author:     Michal Orzel <michal.orzel@xxxxxxx>
AuthorDate: Thu May 5 13:59:06 2022 +0200
Commit:     Julien Grall <jgrall@xxxxxxxxxx>
CommitDate: Mon May 16 18:20:40 2022 +0100

    xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK
    
    Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer
    and can lead to overflow. Currently there is no issue as it is used
    in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE.
    To avoid possible problems, fix the macro.
    
    Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
    Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@xxxxxxx
    Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
    Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
---
 xen/arch/arm/include/asm/processor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/processor.h 
b/xen/arch/arm/include/asm/processor.h
index 852b5f3c24..7a1c4c4410 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -39,7 +39,7 @@
 #define MIDR_VARIANT(midr) \
     (((midr) & MIDR_VARIANT_MASK) >> MIDR_VARIANT_SHIFT)
 #define MIDR_IMPLEMENTOR_SHIFT  24
-#define MIDR_IMPLEMENTOR_MASK   (0xff << MIDR_IMPLEMENTOR_SHIFT)
+#define MIDR_IMPLEMENTOR_MASK   (0xffU << MIDR_IMPLEMENTOR_SHIFT)
 #define MIDR_IMPLEMENTOR(midr) \
     (((midr) & MIDR_IMPLEMENTOR_MASK) >> MIDR_IMPLEMENTOR_SHIFT)
 
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.