[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] xsm/flask: fix MISRA C 2012 Rule 20.7 violations
commit ad0838f4499820db613370feea354ac484544b11 Author: Xenia Ragiadakou <burzalodowa@xxxxxxxxx> AuthorDate: Tue Sep 6 16:02:28 2022 +0200 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Tue Sep 6 16:02:28 2022 +0200 xsm/flask: fix MISRA C 2012 Rule 20.7 violations In macros SIDTAB_HASH(), INIT_SIDTAB_LOCK(), SIDTAB_LOCK() and SIDTAB_UNLOCK(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx> --- xen/xsm/flask/ss/sidtab.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/xsm/flask/ss/sidtab.c b/xen/xsm/flask/ss/sidtab.c index 74babfac9c..69fc3389b3 100644 --- a/xen/xsm/flask/ss/sidtab.c +++ b/xen/xsm/flask/ss/sidtab.c @@ -14,11 +14,11 @@ #include "security.h" #include "sidtab.h" -#define SIDTAB_HASH(sid) (sid & SIDTAB_HASH_MASK) +#define SIDTAB_HASH(sid) ((sid) & SIDTAB_HASH_MASK) -#define INIT_SIDTAB_LOCK(s) spin_lock_init(&s->lock) -#define SIDTAB_LOCK(s) spin_lock(&s->lock) -#define SIDTAB_UNLOCK(s) spin_unlock(&s->lock) +#define INIT_SIDTAB_LOCK(s) spin_lock_init(&(s)->lock) +#define SIDTAB_LOCK(s) spin_lock(&(s)->lock) +#define SIDTAB_UNLOCK(s) spin_unlock(&(s)->lock) int sidtab_init(struct sidtab *s) { -- generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |