[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] xen/arm: vGICv3: Restore the interrupt state correctly



commit aa717d803eb5442c0ab9c6f078b6ff2078092bae
Author:     Ayan Kumar Halder <ayankuma@xxxxxxx>
AuthorDate: Thu Oct 27 20:09:13 2022 +0100
Commit:     Julien Grall <julien@xxxxxxx>
CommitDate: Tue Nov 15 23:01:44 2022 +0000

    xen/arm: vGICv3: Restore the interrupt state correctly
    
    As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current 
interrupt
    state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" 
should be
    used to restore the saved interrupt state.
    
    Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and 
property tables")
    Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
    Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
    Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
    Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
---
 xen/arch/arm/vgic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index c19691ece0..84dc442fc6 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -582,7 +582,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, 
mmio_info_t *info,
             write_atomic(&v->arch.vgic.rdist_pendbase, reg);
         }
 
-        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
+        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
 
         return 1;
     }
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.