[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] x86/MSI: drop "packed" attribute from message data/address structures



commit 40c12ba546729fdcc8b6731f675806dc268a5745
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Feb 22 13:50:59 2023 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Feb 22 13:50:59 2023 +0100

    x86/MSI: drop "packed" attribute from message data/address structures
    
    The attribute has no purpose here and, in the worst case, could lead to
    the compiler generating worse code. In practice, however: No change to
    generated code (surprisingly not even to generated debug info), at least
    with gcc12 and the .config-s I've tried.
    
    Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/include/asm/msi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h
index ec77c66642..a53ade95c9 100644
--- a/xen/arch/x86/include/asm/msi.h
+++ b/xen/arch/x86/include/asm/msi.h
@@ -178,7 +178,7 @@ int msi_free_irq(struct msi_desc *entry);
  * MSI Defined Data Structures
  */
 
-struct __packed msg_data {
+struct msg_data {
     uint32_t vector        :  8;
     uint32_t delivery_mode :  3;    /* 000b: FIXED | 001b: lowest prior */
     uint32_t               :  3;
@@ -187,7 +187,7 @@ struct __packed msg_data {
     uint32_t               : 16;
 };
 
-struct __packed msg_address {
+struct msg_address {
     union {
         struct {
             uint32_t              :  2;
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.