[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] build: run targets cscope,tags,... using tree-wide approach



commit e6e92adf47bf50a9e944efdc123f0bc2e3cb0790
Author:     Michal Orzel <michal.orzel@xxxxxxx>
AuthorDate: Tue Mar 14 10:44:47 2023 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Mar 14 10:44:47 2023 +0100

    build: run targets cscope,tags,... using tree-wide approach
    
    Despite being a matter of taste, in general, there are two main approaches
    when dealing with code tagging: tree-wide, where all the sources are taken
    into account or config-wide, when considering Kconfig options and actually
    built files. At the moment, all_sources variable is defined using SUBDIRS,
    which lists all the directories except arch/, where only $(TARGET_ARCH)
    is taken into account. This makes it difficult to reason about and creates
    fuzzy boundaries being a blocker when considering new directories that
    might be config-dependent (like crypto/ which is missing in SUBDIRS).
    
    For now, switch to the intermediate solution to list all the directories
    in SUBDIRS without exceptions (also include crypto/). This way, the
    approach taken is clear allowing new directories to be listed right away
    without waiting to fix the infrastructure first. In the future, we can
    then add support for config-wide approach.
    
    Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/Makefile b/xen/Makefile
index 2d55bb9401..2710d7327e 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE
        $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
        $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 
'ALL_LIBS=$(ALL_LIBS-y)' $@
 
-SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
+SUBDIRS = xsm arch common crypto drivers lib test
 define all_sources
     ( find include -type f -name '*.h' -print; \
       find $(SUBDIRS) -type f -name '*.[chS]' -print )
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.