[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] x86/shadow: replace memcmp() in sh_resync_l1()
commit 189e4dd36a0940b490f9844d75b2843717216da5 Author: Jan Beulich <jbeulich@xxxxxxxx> AuthorDate: Fri Mar 24 11:10:41 2023 +0100 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Fri Mar 24 11:10:41 2023 +0100 x86/shadow: replace memcmp() in sh_resync_l1() Ordinary scalar operations are used in a multitude of other places, so do so here as well. In fact take the opportunity and drop a local variable then as well, first and foremost to get rid of a bogus cast. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> --- xen/arch/x86/mm/shadow/multi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 106f95cccc..e4dd50e01c 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -1668,9 +1668,8 @@ void sh_resync_l1(struct vcpu *v, mfn_t gl1mfn, mfn_t snpmfn) SHADOW_FOREACH_L1E(sl1mfn, sl1p, &gl1p, 0, { guest_l1e_t gl1e = *gl1p; - guest_l1e_t *snpl1p = (guest_l1e_t *)snp + guest_index(gl1p); - if ( memcmp(snpl1p, &gl1e, sizeof(gl1e)) ) + if ( snp[guest_index(gl1p)].l1 != gl1e.l1 ) { gfn_t gfn; mfn_t gmfn = INVALID_MFN; @@ -1686,7 +1685,7 @@ void sh_resync_l1(struct vcpu *v, mfn_t gl1mfn, mfn_t snpmfn) l1e_propagate_from_guest(v, gl1e, gmfn, &nsl1e, ft_prefetch, p2mt); rc |= shadow_set_l1e(d, sl1p, nsl1e, p2mt, sl1mfn); - *snpl1p = gl1e; + snp[guest_index(gl1p)] = gl1e; } }); -- generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |