[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] include: don't mention stub headers more than once in a make rule



commit 231ab79704cbb5b9be7700287c3b185225d34f1b
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Mar 28 14:20:16 2023 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Mar 28 14:20:16 2023 +0200

    include: don't mention stub headers more than once in a make rule
    
    When !GRANT_TABLE and !PV_SHIM headers-n contains grant_table.h twice,
    causing make to complain "target '...' given more than once in the same
    rule" for the rule generating the stub headers. We don't need duplicate
    entries in headers-n anywhere, so zap them (by using $(sort ...)) right
    where the final value of the variable is constructed.
    
    Fixes: 6bec713f871f ("include/compat: produce stubs for headers not 
otherwise generated")
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
---
 xen/include/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/Makefile b/xen/include/Makefile
index 2da842b3ee..edd5322e88 100644
--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -34,7 +34,7 @@ headers-$(CONFIG_TRACEBUFFER) += compat/trace.h
 headers-$(CONFIG_XENOPROF) += compat/xenoprof.h
 headers-$(CONFIG_XSM_FLASK) += compat/xsm/flask_op.h
 
-headers-n := $(filter-out $(headers-y),$(headers-n) $(headers-))
+headers-n := $(sort $(filter-out $(headers-y),$(headers-n) $(headers-)))
 
 cppflags-y                := -include public/xen-compat.h 
-DXEN_GENERATING_COMPAT_HEADERS
 cppflags-$(CONFIG_X86)    += -m32
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.