[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] CI: Remove all use of /bin/false as a ROM



commit ac58d7fda63fecc6fae24f7824dbe033d001833e
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Wed Apr 26 15:34:30 2023 +0100
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Thu Apr 27 21:44:44 2023 +0100

    CI: Remove all use of /bin/false as a ROM
    
    As the recent work to get PCI Passthrough testing working shows, putting
    `/bin/false` as a ROM into guest context doesn't work so well.
    
    For all ROM paths where we're skipping the build, use a slightly-plausible 
but
    likely non-existent path instead.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
 automation/scripts/build | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index d830cff7b7..197d085f3e 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -67,9 +67,9 @@ else
 
     if [[ "${cc_is_clang}" == "y" ]]; then
         # SeaBIOS cannot be built with clang
-        cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
+        cfgargs+=("--with-system-seabios=/usr/share/no-seabios.bin")
         # iPXE cannot be built with clang
-        cfgargs+=("--with-system-ipxe=/usr/lib/ipxe/ipxe.pxe")
+        cfgargs+=("--with-system-ipxe=/usr/share/no-ipxe.pxe")
         # newlib cannot be built with clang so we cannot build stubdoms
         cfgargs+=("--disable-stubdom")
     fi
@@ -87,7 +87,7 @@ else
 
     # SeaBIOS requires GCC 4.6 or later
     if [[ "${cc_is_gcc}" == "y" && "${cc_ver}" -lt 0x040600 ]]; then
-        cfgargs+=("--with-system-seabios=/bin/false")
+        cfgargs+=("--with-system-seabios=/usr/share/no-seabios.bin")
     fi
 
     ./configure "${cfgargs[@]}"
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.