[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] Arm: drop bogus ALIGN() from linker script



commit a012a4aba1bbe8d01869bb6e4a5c00b032ec34db
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Thu Jun 15 11:00:22 2023 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Jun 15 11:00:22 2023 +0200

    Arm: drop bogus ALIGN() from linker script
    
    Having ALIGN() inside a section definition usually makes sense only with
    a label definition following (an exception case is a few lines out of
    context, where cache line sharing is intended to be avoided).
    Constituents of .bss.page_aligned need to specify their own alignment
    correctly anyway, or else they're susceptible to link order changing.
    This requirement is already met: Arm-specific code has no such object,
    while common (EFI) code has another one. That one has suitable alignment
    specified.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
 xen/arch/arm/xen.lds.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 6ca3caefe6..be58c2c395 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -199,7 +199,6 @@ SECTIONS
   .bss : {                     /* BSS */
        __bss_start = .;
        *(.bss.stack_aligned)
-       . = ALIGN(PAGE_SIZE);
        *(.bss.page_aligned)
        . = ALIGN(PAGE_SIZE);
        __per_cpu_start = .;
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.