[xen master] x86/APIC: adjustments to error_interrupt() loop

[patchbot@xxxxxxx]

commit 2acec876949e2488dfeffab3c531984b91d33cf5
Author:     Elliott Mitchell <ehem+xen@xxxxxxx>
AuthorDate: Thu Jul 13 16:59:18 2023 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Jul 13 16:59:18 2023 +0200

    x86/APIC: adjustments to error_interrupt() loop
    
    ARRAY_SIZE() makes future maintainance easier and thus less likely for
    bugs to occur.
    
    Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/apic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
index 08459228e0..ce556b2684 100644
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1412,7 +1412,7 @@ static void cf_check error_interrupt(struct cpu_user_regs 
*regs)
     };
     const char *entries[ARRAY_SIZE(esr_fields)];
     unsigned int v, v1;
-    int i;
+    unsigned int i;
 
     /* First tickle the hardware, only then report what went on. -- REW */
     v = apic_read(APIC_ESR);
@@ -1420,7 +1420,7 @@ static void cf_check error_interrupt(struct cpu_user_regs 
*regs)
     v1 = apic_read(APIC_ESR);
     ack_APIC_irq();
 
-    for ( i = 7; i >= 0; --i )
+    for ( i = 0; i < ARRAY_SIZE(entries); ++i )
         entries[i] = v1 & (1 << i) ? esr_fields[i] : "";
     printk(XENLOG_DEBUG
            "APIC error on CPU%u: %02x(%02x)%s%s%s%s%s%s%s%s\n",
--
generated by git-patchbot for /home/xen/git/xen.git#master