[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] libxl: Add missing libxl__virtio_devtype to device_type_tbl array



commit d8bd8d2db483a17adf1d6ed06659bf36e3ba6132
Author:     Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
AuthorDate: Fri Jul 28 09:41:05 2023 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Jul 28 09:41:05 2023 +0200

    libxl: Add missing libxl__virtio_devtype to device_type_tbl array
    
    Without it being present it won't be possible to use some
    libxl__device_type's callbacks for virtio devices as the common code
    can only invoke these callbacks (by dereferencing a pointer) for valid
    libxl__device_type's elements when iterating over device_type_tbl[].
    
    Please note, there is no issue within current the code base as virtio
    devices don't use callbacks that depend on libxl__virtio_devtype
    presence in device_type_tbl[]. The issue will appear as soon as we start
    using these callbacks (for example, dm_needed).
    
    Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
    Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
    Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
---
 tools/libs/light/libxl_create.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 393c535579..c91059d713 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1887,6 +1887,7 @@ const libxl__device_type *device_type_tbl[] = {
     &libxl__dtdev_devtype,
     &libxl__vdispl_devtype,
     &libxl__vsnd_devtype,
+    &libxl__virtio_devtype,
     NULL
 };
 
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.