[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen stable-4.14] x86/cpuid: Drop special_features[]
commit 0eafe6ac6ac0df7c92dfb50caf02c27a16cb4a3c Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> AuthorDate: Mon Jun 7 13:38:53 2021 +0100 Commit: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> CommitDate: Thu Aug 3 19:14:19 2023 +0100 x86/cpuid: Drop special_features[] While the ! annotation is useful to indicate that something special is happening, an array of bits is not. Drop it, to prevent mistakes. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> (cherry picked from commit 69e1472d21cf7e5cf0795ef38b99d00de78a910e) x86/cpuid: Half revert "x86/cpuid: Drop special_features[]" xen-cpuid does print out the list of special features, and this is helpful to keep. Fixes: 69e1472d21cf ("x86/cpuid: Drop special_features[]") Reported-by: Jan Beulich <JBeulich@xxxxxxxx> Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> (cherry picked from commit 0ba0663b1b32d9351890dfd02bdebb3d238897bd) --- xen/arch/x86/cpuid.c | 2 -- xen/include/asm-x86/cpuid.h | 1 - 2 files changed, 3 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 587de66545..3a7c3f497c 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -14,7 +14,6 @@ #include <asm/xstate.h> const uint32_t known_features[] = INIT_KNOWN_FEATURES; -const uint32_t special_features[] = INIT_SPECIAL_FEATURES; static const uint32_t pv_max_featuremask[] = INIT_PV_MAX_FEATURES; static const uint32_t hvm_shadow_max_featuremask[] = INIT_HVM_SHADOW_MAX_FEATURES; @@ -1133,7 +1132,6 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, static void __init __maybe_unused build_assertions(void) { BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS); - BUILD_BUG_ON(ARRAY_SIZE(special_features) != FSCAPINTS); BUILD_BUG_ON(ARRAY_SIZE(pv_max_featuremask) != FSCAPINTS); BUILD_BUG_ON(ARRAY_SIZE(hvm_shadow_max_featuremask) != FSCAPINTS); BUILD_BUG_ON(ARRAY_SIZE(hvm_hap_max_featuremask) != FSCAPINTS); diff --git a/xen/include/asm-x86/cpuid.h b/xen/include/asm-x86/cpuid.h index 7baf6c9628..46904061d0 100644 --- a/xen/include/asm-x86/cpuid.h +++ b/xen/include/asm-x86/cpuid.h @@ -14,7 +14,6 @@ #include <public/sysctl.h> extern const uint32_t known_features[FSCAPINTS]; -extern const uint32_t special_features[FSCAPINTS]; void init_guest_cpuid(void); -- generated by git-patchbot for /home/xen/git/xen.git#stable-4.14
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |